UM0182 HDLC Library Bugs- Can't have passed reasonable tests.

[donald]

Posted on February 27, 2006 at 12:25

UM0182 HDLC Library Bugs- Can't have passed reasonable tests.

[donald]

Posted on February 26, 2006 at 01:50

I note that in the HDLC Library UM0182 that I downloaded just recently that the file \include\hdlc.h dated internallay as 23/03/2005 contains a serious bug that shows that the code was never well tested.

The lines

#define HDLC_RECEIVEBUFFER_BASE_LO (HDLC_BASE + 0x0800)

#define HDLC_TRANSMITBUFFER_BASE_LO (HDLC_BASE + 0x0880)

#define HDLC_RECEIVEBUFFER_BASE_HI (HDLC_BASE + 0x0810)

#define HDLC_TRANSMITBUFFER_BASE_HI (HDLC_BASE + 0x0890)

Should be

#define HDLC_RECEIVEBUFFER_BASE_LO (HDLC_BASE + 0x0800)

#define HDLC_TRANSMITBUFFER_BASE_LO (HDLC_BASE + 0x0880)

#define HDLC_RECEIVEBUFFER_BASE_HI (HDLC_BASE + 0x0840)

#define HDLC_TRANSMITBUFFER_BASE_HI (HDLC_BASE + 0x08C0)

Can ST explain their practive of issuing code without testing it. Is this representative if the whole library. So far the bugs I have found in the rest of the library could have slipped past testing (GPIO Bug, non clearing of RCCU_PER bits bug causing excess current consumption).

In the absence of clear doco on the HDLC and tested sample code how is one meant to approach its use. Is there any document we are missing that correctly describes HDLC ?

(Seperate posts on HDLC doco)

[davidbellegarde9]

Posted on February 27, 2006 at 12:25

As I know, this bug will be corrected in few days on Internet.

BTW, HDLC.c and HDLC.h are not a part of the library. Just example to be getting started with the HDLC. And this define are not used by the example software.

These files are not tested as exhaustively as the library is.

There is no other available document.