ADC Callback not firing with DMA

[evanpol]

Hi all,

 

I've recently been working on a Nucleo H723ZG with a working implementation that allows for ADC reading over DMA. I've got a Timer event that triggers it at 20kHz and it was reading and processing multiple ADCs.

 

I've shifted to using a custom developed board with a surface mounted STMH733VGT6. I've configured the ADCs and timers to what I believe is the exact same as before. I have verified that there is nothing wrong with the ADC circuitry by initially setting them up using poll for conversion, I was able to get valuable data out of the board doing this.

When I went to setup the ADCs to use DMA however I started to have issues, I believe that the

HAL_ADC_ConvCpltCallback isn't being called but I am not sure why, I set a break point in there which is never reached. Below I have copied in my TIM1 init function as well as my ADC1 init function in hopes that it may help someone assist me with my issue. 

 

Really appreciate you taking the time to read this and assist me, thank you, any help is greatly appreciated.

 

static void MX_TIM1_Init(void)

{

  /* USER CODE BEGIN TIM1_Init 0 */

  /* USER CODE END TIM1_Init 0 */

  TIM_ClockConfigTypeDef sClockSourceConfig = {0};

  TIM_MasterConfigTypeDef sMasterConfig = {0};

  TIM_OC_InitTypeDef sConfigOC = {0};

  TIM_BreakDeadTimeConfigTypeDef sBreakDeadTimeConfig = {0};

  /* USER CODE BEGIN TIM1_Init 1 */

  /* USER CODE END TIM1_Init 1 */

  htim1.Instance = TIM1;

  htim1.Init.Prescaler = 137.5-1;

  htim1.Init.CounterMode = TIM_COUNTERMODE_CENTERALIGNED1;

  htim1.Init.Period = 50-1;

  htim1.Init.ClockDivision = TIM_CLOCKDIVISION_DIV1;

  htim1.Init.RepetitionCounter = 1;

  htim1.Init.AutoReloadPreload = TIM_AUTORELOAD_PRELOAD_DISABLE;

  if (HAL_TIM_Base_Init(&htim1) != HAL_OK)

  {

    Error_Handler();

  }

  sClockSourceConfig.ClockSource = TIM_CLOCKSOURCE_INTERNAL;

  if (HAL_TIM_ConfigClockSource(&htim1, &sClockSourceConfig) != HAL_OK)

  {

    Error_Handler();

  }

  if (HAL_TIM_PWM_Init(&htim1) != HAL_OK)

  {

    Error_Handler();

  }

  sMasterConfig.MasterOutputTrigger = TIM_TRGO_OC1REF;  // UPDATE triggers ADC on every timer period

  sMasterConfig.MasterOutputTrigger2 = TIM_TRGO2_RESET;

  sMasterConfig.MasterSlaveMode = TIM_MASTERSLAVEMODE_DISABLE;

  if (HAL_TIMEx_MasterConfigSynchronization(&htim1, &sMasterConfig) != HAL_OK)

  {

    Error_Handler();

  }

  sConfigOC.OCMode = TIM_OCMODE_PWM1;

  sConfigOC.Pulse = 0;

  sConfigOC.OCPolarity = TIM_OCPOLARITY_HIGH;

  sConfigOC.OCNPolarity = TIM_OCNPOLARITY_HIGH;

  sConfigOC.OCFastMode = TIM_OCFAST_DISABLE;

  sConfigOC.OCIdleState = TIM_OCIDLESTATE_RESET;

  sConfigOC.OCNIdleState = TIM_OCNIDLESTATE_RESET;

  if (HAL_TIM_PWM_ConfigChannel(&htim1, &sConfigOC, TIM_CHANNEL_1) != HAL_OK)

  {

    Error_Handler();

  }

  if (HAL_TIM_PWM_ConfigChannel(&htim1, &sConfigOC, TIM_CHANNEL_2) != HAL_OK)

  {

    Error_Handler();

  }

  if (HAL_TIM_PWM_ConfigChannel(&htim1, &sConfigOC, TIM_CHANNEL_3) != HAL_OK)

  {

    Error_Handler();

  }

  sBreakDeadTimeConfig.OffStateRunMode = TIM_OSSR_DISABLE;

  sBreakDeadTimeConfig.OffStateIDLEMode = TIM_OSSI_DISABLE;

  sBreakDeadTimeConfig.LockLevel = TIM_LOCKLEVEL_OFF;

  sBreakDeadTimeConfig.DeadTime = 5;

  sBreakDeadTimeConfig.BreakState = TIM_BREAK_DISABLE;

  sBreakDeadTimeConfig.BreakPolarity = TIM_BREAKPOLARITY_HIGH;

  sBreakDeadTimeConfig.BreakFilter = 0;

  sBreakDeadTimeConfig.Break2State = TIM_BREAK2_DISABLE;

  sBreakDeadTimeConfig.Break2Polarity = TIM_BREAK2POLARITY_HIGH;

  sBreakDeadTimeConfig.Break2Filter = 0;

  sBreakDeadTimeConfig.AutomaticOutput = TIM_AUTOMATICOUTPUT_DISABLE;

  if (HAL_TIMEx_ConfigBreakDeadTime(&htim1, &sBreakDeadTimeConfig) != HAL_OK)

  {

    Error_Handler();

  }

  /* USER CODE BEGIN TIM1_Init 2 */

  /* USER CODE END TIM1_Init 2 */

  HAL_TIM_MspPostInit(&htim1);

}

 -------------------------------------------------------------------------------------------------------

static void MX_ADC1_Init(void)

{

  /* USER CODE BEGIN ADC1_Init 0 */

  /* USER CODE END ADC1_Init 0 */

  ADC_MultiModeTypeDef multimode = {0};

  ADC_ChannelConfTypeDef sConfig = {0};

  /* USER CODE BEGIN ADC1_Init 1 */

  /* USER CODE END ADC1_Init 1 */

  /** Common config

  */

  hadc1.Instance = ADC1;

  hadc1.Init.ClockPrescaler = ADC_CLOCK_ASYNC_DIV1;

  hadc1.Init.Resolution = ADC_RESOLUTION_16B;

  hadc1.Init.ScanConvMode = ADC_SCAN_ENABLE;

  hadc1.Init.EOCSelection = ADC_EOC_SINGLE_CONV;

  hadc1.Init.LowPowerAutoWait = DISABLE;

  hadc1.Init.ContinuousConvMode = DISABLE;

  hadc1.Init.NbrOfConversion = 8;

  hadc1.Init.DiscontinuousConvMode = DISABLE;

  hadc1.Init.ExternalTrigConv = ADC_EXTERNALTRIG_T1_TRGO;

  hadc1.Init.ExternalTrigConvEdge = ADC_EXTERNALTRIGCONVEDGE_RISING;

  hadc1.Init.ConversionDataManagement = ADC_CONVERSIONDATA_DMA_CIRCULAR;

  hadc1.Init.Overrun = ADC_OVR_DATA_PRESERVED;

  hadc1.Init.LeftBitShift = ADC_LEFTBITSHIFT_NONE;

  hadc1.Init.OversamplingMode = DISABLE;

  hadc1.Init.Oversampling.Ratio = 1;

  if (HAL_ADC_Init(&hadc1) != HAL_OK)

  {

    Error_Handler();

  }

  /** Configure the ADC multi-mode

  */

  multimode.Mode = ADC_MODE_INDEPENDENT;

  if (HAL_ADCEx_MultiModeConfigChannel(&hadc1, &multimode) != HAL_OK)

  {

    Error_Handler();

  }

  /** Configure Regular Channel

  */

  sConfig.Channel = ADC_CHANNEL_3;

  sConfig.Rank = ADC_REGULAR_RANK_1;

  sConfig.SamplingTime = ADC_SAMPLETIME_8CYCLES_5;

  sConfig.SingleDiff = ADC_SINGLE_ENDED;

  sConfig.OffsetNumber = ADC_OFFSET_NONE;

  sConfig.Offset = 0;

  sConfig.OffsetSignedSaturation = DISABLE;

  if (HAL_ADC_ConfigChannel(&hadc1, &sConfig) != HAL_OK)

  {

    Error_Handler();

  }

  /** Configure Regular Channel

  */

  sConfig.Channel = ADC_CHANNEL_4;

  sConfig.Rank = ADC_REGULAR_RANK_2;

  if (HAL_ADC_ConfigChannel(&hadc1, &sConfig) != HAL_OK)

  {

    Error_Handler();

  }

  /** Configure Regular Channel

  */

  sConfig.Channel = ADC_CHANNEL_5;

  sConfig.Rank = ADC_REGULAR_RANK_3;

  if (HAL_ADC_ConfigChannel(&hadc1, &sConfig) != HAL_OK)

  {

    Error_Handler();

  }

  /** Configure Regular Channel

  */

  sConfig.Channel = ADC_CHANNEL_8;

  sConfig.Rank = ADC_REGULAR_RANK_4;

  if (HAL_ADC_ConfigChannel(&hadc1, &sConfig) != HAL_OK)

  {

    Error_Handler();

  }

  /** Configure Regular Channel

  */

  sConfig.Channel = ADC_CHANNEL_10;

  sConfig.Rank = ADC_REGULAR_RANK_5;

  if (HAL_ADC_ConfigChannel(&hadc1, &sConfig) != HAL_OK)

  {

    Error_Handler();

  }

  /** Configure Regular Channel

  */

  sConfig.Channel = ADC_CHANNEL_11;

  sConfig.Rank = ADC_REGULAR_RANK_6;

  if (HAL_ADC_ConfigChannel(&hadc1, &sConfig) != HAL_OK)

  {

    Error_Handler();

  }

  /** Configure Regular Channel

  */

  sConfig.Channel = ADC_CHANNEL_15;

  sConfig.Rank = ADC_REGULAR_RANK_7;

  if (HAL_ADC_ConfigChannel(&hadc1, &sConfig) != HAL_OK)

  {

    Error_Handler();

  }

  /** Configure Regular Channel

  */

  sConfig.Channel = ADC_CHANNEL_18;

  sConfig.Rank = ADC_REGULAR_RANK_8;

  if (HAL_ADC_ConfigChannel(&hadc1, &sConfig) != HAL_OK)

  {

    Error_Handler();

  }

[Ozone]

> Below I have copied in my TIM1 init function as well as my ADC1 init function in hopes that it may help someone assist me with my issue. 

There is an "insert/edit code sample" menu item ("</>"), please use it next time.

> When I went to setup the ADCs to use DMA however I started to have issues, I believe that the

HAL_ADC_ConvCpltCallback isn't being called but I am not sure why, I set a break point in there which is never reached.

Set a breakpoint directly in the interrupt handler, where this callback is supposedly called.
The best place is where you first check for an interrupt flag set.
And don't activate/open any peripheral ADC register view at that point, or you will get "surprising" results.

[TDK]

Are ADC and DMA interrupts enabled? Attach your IOC.

You haven't shown any code that actually starts the ADC.

>  htim1.Init.Prescaler = 137.5-1;

The prescaler is an integer. Not the issue here but this is weird.

[evanpol]

Hello @TDK and @Ozone ,

 

To answer your questions, yes ADC and DMA interrupts are enabled. Before the main while loop of my code I call all of the regular inits but then also the following functions for TIM1 and TIM3, and ADC1 and ADC3 respectively. The ADCs are configured to trigger off Timer 1 TRGO, which is set to OC1REF, I had no issues with this setup on my nucleo.

HAL_TIM_Base_Start_IT()
HAL_ADC_Start_DMA()

 Attached is an image of my NVIC setup in cubeMX , I realised earlier that the priorities were all 0 and thought that may be causing issues so changed the system to what is depicted below, this did not fix it though.

The only change I can think of between the two implementations is that I have more values being read on a single dma stream (up to 8).

 

 

I am a bit confused as to what to try next, @Ozone I'm not quite sure what you mean by placing it in the interrupt handler instead, I'm not sure where that would be.

[TDK]

I don't see any issues with the code or screenshots you've presented. I suspect the issue is elsewhere. Systick priority should probably be higher but I don't think that's the main issue.

[evanpol]

Issue has been found, my buffer for the DMA had defaulted to a memory location that it could not access. Defining a new memory region in the linker script and initializing the buffer there solved the issue.