gnss libary includded in X-CUBE-GNSS1 libary

[mfried]

i want to report a bug entered in the GNSS libary. in the LibNMEA in the file NMEA_parser.c

in line 679:

        if (strcmp((char *)app[0], "$GPGST") == 0 || strcmp((char *)app[0], "$GNGST"))

missing the == 0 part.

and in line 734

        if (strcmp((char *)app[0], "$GPRMC") == 0 | strcmp((char *)app[0], "$GNRMC") == 0)

puting binary or ( | ) insted of logic or ( || ).

this is only after the latast changes adding support to GN family.

 

[STTwo-32]

Hello @mfried 

Thank you so much for escalating this. I've sent your correction request for the « ==0 » to the concerned team for correction on the future releases (under internal ticket number 203896). But for the ||, I think it is correct since we need a logical and not a bitwise operator on the if conditions.

Best Regards.

STTwo-32