PWM backlight not working.

[Lmoio.1]

Can you please check my device tree configuration?

Backlight as a GPIO is working correctly, but when i try to use it as pwm, the pin line is always fixed to low.

Inside my .dts:

This is my panel definition:

panel {
		compatible = "newkoro,display","simple-panel";
		//enable-gpios = <&gpioe 12 GPIO_ACTIVE_HIGH>;
 //reset-gpios = <&gpioe 11 GPIO_ACTIVE_HIGH>;
		backlight = <&backlight>;
		power-supply = <&vdd>;
 	 	status = "okay";	
		port@0{
			//reg = <0>;
			panel_in: endpoint {
				remote-endpoint = <&ltdc_ep0_out>;			
			};
	
		};	
	};

 

 

This is backlight as simple gpio (working)

//backlight: panel-backlight {
 
 // compatible = "gpio-backlight";
 
 // gpios = <&gpioe 4 GPIO_ACTIVE_HIGH>;
 
 //default-off;
 
 //};

 

This is backlight as pwm (not working)

 

backlight: panel-backlight {
 
 compatible = "pwm-backlight";
 
 pwms = <&backlight_pwm 0 100000 0>;
 
 brightness-levels = <0 31 63 95 127 159 191 223 255>;
 
 default-brightness-level = <8>;
 
 status = "okay";
 
 //power-supply = <&reg_5v2>; /* 3V3_BACKLIGHT */
 
 };

 

and this is timer defs:

 

&timers15 {
 
 status = "okay";
 
 
 backlight_pwm: pwm {
 
 pinctrl-names = "default", "sleep";
 
 pinctrl-0 = <&pwm15_pins_a>;
 
 pinctrl-1 = <&pwm15_sleep_pins_a>;
 
 status = "okay";
 
 //#pwm-cells = <2>;
 
 };
 
};

 

inside pinctrl i have:

 pwm15_pins_a: pwm15-0 {
 
 pins {
 
 pinmux = <STM32_PINMUX('E', 4, AF4)>; /* TIM15_CH1N */
 
 bias-disable;
 
 drive-push-pull;
 
 slew-rate = <0>;
 
 };
 
 };
 
 
 pwm15_sleep_pins_a: pwm15-sleep-0 {
 
 pins {
 
 pinmux = <STM32_PINMUX('E', 4, ANALOG)>; /* TIM15_CH1N */
 
 };
 
 };

thank you

[Paul1]

People likely to ask:

• What STM part number?
• How is clock source for PWM configured?

I use MX to configure. I have an STM32L476 Nucleo sample project with PWM output working if you'd like a zip. You could dig through and see the MX generated PWM setup code, and my use of it.

Paul

[Lmoio.1]

Hi Paul,

thank you for answering.

I'm working with STM32MP157c.

I need .dts configuration, MX output files are mostly incomplete, so i don't think it would help.

[PatrickF]

Hi,

(it seems you are also in direct contact with regional FAE for same topic, so you might receive answer by other channels)

In our DT examples (for DK2 and EV1 board), I confirm timer15 is used for CSI/HSI oscillator regular calibration.

So it cannot be used for other purposes.

Please try commenting the related lines in your DT:

&rcc {
	/* st,hsi-cal; */
	/* st,csi-cal; */
	/* st,cal-sec = <60>; */
...
};
...
&timers15 {
	/* secure-status = "okay"; */
	/* st,hsi-cal-input = <7>; */
	/* st,csi-cal-input = <8>; */
};

But as this will stop the CSI/HSI calibration, it might not fit some of your clock constrains if non-calibrated accuracy is not enough.

Alternatively, to free timer15 and still use calibration, timer12 could be used for CSI/HSI calibration.

e.g.

&timers12 {
	secure-status = "okay";
	st,hsi-cal-input = <1>;
	st,csi-cal-input = <2>;
};

Regards.

In order to give better visibility on the answered topics, please click on 'Select as Best' on the reply which solved your issue or answered your question. See also 'Best Answers'

[Lmoio.1]

Hi @PatrickF​ 

You were correct, I modified tf-a dts removing calibration on timer15 and now I can controll pwm as expected.

However, I still have doubts about the pwm-backlight driver:

1. Backlight starts off, no matter what default-brightness-level I configure. I must manually do "echo 0 > /sys/class/backlight/panel-backlight/bl_power"
2. When backlight is enabled, i don't see the image on the display (display becomes greyish but no image)

Thank you

[Lmoio.1]

UPDATE:

If I remove backlight property from the display:

panel {

compatible = "newkoro,display","simple-panel";

//enable-gpios = <&gpioe 12 GPIO_ACTIVE_HIGH>;

//reset-gpios = <&gpioe 11 GPIO_ACTIVE_HIGH>;

//backlight = <&backlight>;

power-supply = <&vdd>;

status = "okay";

port@0{

//reg = <0>;

panel_in: endpoint {

remote-endpoint = <&ltdc_ep0_out>;

};

};

Backlight starts on, i can see the image on the display and regolate pwm duty.

I was wondering, is panel-simple.c driver able of using backlight as pwm?

[batuhanky]

Hi @Lmoio.1 , I am also facing the same problem. When I add panel-backlight property to the panel node, there is no pwm and enable output, but when I comment out this property from the node, I can control enable and pwm. I am using STM32MP135 SoM from PHYTEC, can you check my dts file? BTW, this is the working dts.

// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
/*
 * Copyright (C) 2023 PHYTEC Messtechnik GmbH
 * Authors: Christophe Parant <[e-mail]>
 */

 /dts-v1/;

 #include "stm32mp1-phycore-custom-carrier.dtsi"
 
 / {
 model = "CUSTOM CARRIER";
 compatible = "phytec,stm32mp135f-pbacd10", "phytec,stm32mp135f-pcl076-emmc",
 "phytec,stm32mp135f-pcl076", "st,stm32mp135";
 
 memory@c0000000 {
 reg = <0xc0000000 0x20000000>;
 };
 
 reserved-memory {
 #address-cells = <1>;
 #size-cells = <1>;
 ranges;
 
 optee_framebuffer@dd000000 {
 reg = <0xdd000000 0x1000000>;
 no-map;
 };
 
 optee@de000000 {
 reg = <0xde000000 0x2000000>;
 no-map;
 };
 };

 panel_rgb: rgb-panel {
		compatible = "panel-dpi";
 label = "dt304b-lcd";
		reset-gpios = <&gpioi 0 GPIO_ACTIVE_HIGH>;
		//backlight = <&panel_backlight>;

		data-mapping = "bgr666";

		status = "okay";

		width-mm = <115>;
		height-mm = <80>;

		port {
			panel_in_rgb: endpoint {
				remote-endpoint = <&ltdc_ep0_out>;
			};
		};
//SATOZ 4.3INCH PANEL TIMINGS
		panel-timing {
 clock-frequency = <9000000>;
 hactive = <480>;
			vactive = <272>;
 hfront-porch = <8>;
			hback-porch = <43>;
			hsync-len = <4>;
			vback-porch = <12>;
			vfront-porch = <8>;
			vsync-len = <4>;
		};
	};

 panel_backlight: panel-backlight {
 compatible = "pwm-backlight";
 status = "okay";
 pwms = <&pwm_8 2 50000 0>;
 enable-gpios = <&gpiob 1 GPIO_ACTIVE_HIGH>;
 power-supply = <&scmi_vdd>;
 brightness-levels = <0 4 8 16 32 64 128 255>;
 default-brightness-level = <6>;
 };

 user-leds {
 compatible = "gpio-leds";

 sys-green-led {
 gpios = <&gpiob 13 GPIO_ACTIVE_HIGH>;
 linux,default-trigger = "heartbeat";
 };

 sys-red-led {
 gpios = <&gpiob 5 GPIO_ACTIVE_HIGH>;
 linux,default-trigger = "gpio";
 default-state = "on";
 };
 };
 };

 &ltdc {
 pinctrl-names = "default", "sleep";
 pinctrl-0 = <&ltdc_pins_mx>;
 pinctrl-1 = <&ltdc_sleep_pins_mx>;

 status = "okay";
 port {
 #address-cells = <1>;
 #size-cells = <0>;

 ltdc_ep0_out: endpoint@0 {
 reg = <0>;
 remote-endpoint = <&panel_in_rgb>;
 };
 };
};

&timers8 {
	/delete-property/dmas;
	/delete-property/dma-names;
	status = "okay";
	pwm_8: pwm {
		pinctrl-0 = <&tim8_pwm_pins_mx>;
		pinctrl-1 = <&tim8_pwm_sleep_pins_mx>;
		pinctrl-names = "default", "sleep";
		status = "okay";
	};
};

&i2c5 {
 /delete-node/i2c_rtc;
 /delete-node/tlv320;
	goodix: goodix_ts@14 {
		compatible = "goodix,gt911";
		reg = <0x14>;
		interrupt-parent = <&gpiof>;
 interrupts = <5 IRQ_TYPE_EDGE_FALLING>;
 interrupt-controller;
		reset-gpios = <&gpiog 12 GPIO_ACTIVE_LOW>;
		touchscreen-size-x = <480>;
		touchscreen-size-y = <272>;
		status = "okay";
	};
};

 

[NPal.2]

Hi @Lmoio.1​ , thanks for putting up this query. I am running into exact similar issue. Its just that I am using stm32mp157a and timer4 channel 4 as pwm out.

Getting  some new error when I performed grep in demsg :

 pwm-backlight: probe of backlight failed with error -22

@PatrickF​ and all the members in the chain requesting for the input.

[Lmoio.1]

Hi,

can you leave only timer configuration [&timers4 in your case] and verify pwm is working? (check under /sys/class/pwm)..

I'll attach STM workshop about pwms. Hope it's usefull.

[NPal.2]

@Lmoio.1​  Thanks for suggestions. PWM is working perfectly. Driver also picked up correctly now. But there is not variation of backlight happening even though changing brightness levels.

Here is the device tree working (for atleast binding to driver) :

 backlight: backlight {
 
 u-boot,dm-pre-reloc;
 compatible = "pwm-backlight";
 pwms = <&bl_pwm 0 500000 PWM_POLARITY_INVERTED>;
 brightness-levels = <0 4 8 16 32 64 128 255>;
 default-brightness-level = <2>;
 power-supply = <&vdd>;
 enable-gpios = <&gpioc 2 GPIO_ACTIVE_HIGH>;
 status = "okay";
 };

It comes up as : /sys/class/backlight/backlight in sysfs interface.

[Lmoio.1]

Try

echo 0 > /sys/class/backlight/backlight/bl_power