weston-touch-calibrator on scarthgap has stopped working

[ChrisRCAL]

Hello,

I currently upgraded to Scarthgap, and noticed that weston-touch-calibrator does not work anymore. I have tried it on a custom board and a stm32mp135-disco board, and they exhibit the same behavior. 

It first loads just fine, but once you touch the cross no check-mark or cross appears on the screen. If you do 
root@stm32mp13-disco:~# weston-touch-calibrator --debug "/sys/devices/platform/soc/5c007000.bus/4c006000.i2c/i2c-1/1-005d/input/input0/event0"

could not load cursor 'dnd-move'
could not load cursor 'dnd-copy'
could not load cursor 'dnd-none'
Configure calibrator window to size 480x272
Down[0] (0.183333, 0.106618)
Finish[0]
Conv[0] (0.150000, 0.099265)
Down[1] (0.166667, 0.139706)
Finish[1]
Conv[1] (0.850000, 0.128676)
Down[2] (0.172917, 0.202206)
Finish[2]
Conv[2] (0.200000, 0.801471)
Down[3] (0.154167, 0.091912)
Finish[3]
got all touches
Conv[3] (0.700000, 0.750000)
calibration test error: 1.050614, -1.262112
weston-touch-calibrator error: Calibration verification failed, too large error.

It clearly is registering the touches, but it is not drawing the feedback or updating the location of the next touch point. I do not know if this is an ST issue or a Weston issue. 

Any recommendations is useful, thank you. 

[pjasicek]

Hi,

We are having the exact same issue when updating from Yocto Kirkstone (4.0, using Weston 10.0.2) to Scarthgap (5.0, using Weston 13.0.1).

We are using different board - i.MX6DL SoC on Toradex SoM.

I checked for possible differences between the touch-calibrator sources between these two versions and they are 1:1 identical, so the issue must be somewhere in Weston.

[ChrisRCAL]

Hello,

I was thinking the same when I also checked the differences. There was nothing glaringly wrong. Since its capacitance, we kind of lucked out and was able to just remove calibrating altogether. 

I did notice though if you open up another terminal and you ran lets say weston-calibrator, it would actually trigger a redraw on the screen. Then you would have to kill weston-calibrator, touch the screen, rerun weston-calibrator continue this pattern until done. This sequence actually ran the weston-touch-calibrator, and provided a proper calibration. Clearly this is not acceptable for use, but a horrible work-around if someone needs it. 

[pjasicek]

Hi,

This issue is solved by applying following patch to the Weston 13.0.1 (Scarthgap's current version):

https://gitlab.freedesktop.org/wayland/weston/-/commit/a5c5702112a9ccbf6abbbaac6078982f5f84bb2e